-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp hub issue
commands
#1099
Conversation
- `hub issue` now displays color based on issue open/closed state - `hub issue` no longer displays HTML URL since it was noisy - `hub issue` no longer lists pull requests - `hub issue create` tweaks for compatibility with `hub release create`
cmdCreateIssue = &Command{ | ||
Key: "create", | ||
Run: createIssue, | ||
Usage: "issue create [-m <MESSAGE>|-f <FILE>] [-l <LABELS>]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe Usage and Long of subcommand are never used. Actually putting something in there can be misleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage
should be displayed in cases when you passed an invalid flag, and Usage
and Long
are both used for generating documentation for a command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage and Long are both used for generating documentation for a command.
That is not true today for subcommands: either open an issue to make hub help issue create
display the help for the subcommand, or just remove the doc here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, you're right. For subcommands, these fields aren't consulted yet. For now, let's keep them up to date still, at least as some sort of "code" documentation, and we'll figure out how to hook subcommands into the global help system.
I can confirm that this PR also works with Ubuntu 15.10 (where hub 2.2.3 failed to retrieve anything). Sweet, thanks! |
Use a formatter to choose the display of issues like `git log --format`.
This allows accumulating values across repeated arguments.
Renamed some existing placeholders and added new ones such as milestone number/title, raw labels, comma-separated assignees, and number of comments.
@pcorpet I've pushed some extra features and will merge this to master as the first iteration of the new
|
Instead, specify timezone offsets explicitly so that different environments interpret the time identically.
Cool, thanks. Do you have an idea of a feature / issue I could help with to get a new release of hub with the code currently in master? (I saw you created a 2.2.5 but it seems to cherry-pick only some small fixes). |
Your help is greatly appreciated. Here are my ideas for the next release: #1232 Obviously, not everything will probably make it in. I'm leaving on vacation for 2 weeks next week, so by the end of this week I was thinking to try to push a prerelease with the stuff currently in master. |
This marks
hub issue
family of commands coming out of beta.hub issue
cleaner outputhub issue -s all
All commands reimplemented using
simpleApi
and not go-octokithub issue create
small tweaks for compatibility withhub release create
Todo:
Implement otherhub issue
filtering optionshub issue --format=...
option to choose which fields to output a lagit log
Cache previously fetched pages locallyhub issue edit
command to change labels, assignee, closed/open statehub issue comment
command to add a comment to the thread?Ability to list all your issues a la Issues Dashboard, i.e. not project-specific?Flag to specify a repository to manage issues for, e.g. if not in a git working directory?